Winch aarch64 dynamic heap #9252
Open
+236
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subscribe to Label Action
This issue or pull request has been labeled: "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Comment on lines
238
to
240
| fn cmov(&mut self, src: Reg, dst: Reg, cc: IntCmpKind, size: OperandSize) { | ||
| self.asm.jmp_if_resolved(Cond::from(cc).invert(), 12); | ||
| self.asm.mov_rr(src, dst, size) |
There was a problem hiding this comment.
I think it'd be better to handle this instruction via csel. Any particular reason you decided to go this route?
There was a problem hiding this comment.
You're right, I didn't think about it
| todo!() | ||
| fn checked_uadd(&mut self, dst: Reg, lhs: Reg, rhs: RegImm, size: OperandSize, trap: TrapCode) { | ||
| self.add(dst, lhs, rhs, size); | ||
| self.asm.trapif(Cond::Vs, trap); |
There was a problem hiding this comment.
I believe here we'd want to use Cond::Hs? The Cond::Vs is for signed overflow. (Ref: https://developer.arm.com/documentation/dui0801/l/Condition-Codes/Carry-flag)
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@vulc41n it looks like an update to the filetests is needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
This PR implements everything needed to run winch for aarch64 with dynamic heap. It implements the following macro instructions :
trap,trapif,cmovandchecked_add.